phac-nml / irida-next

IRIDA Next
https://phac-nml.github.io/irida-next/
Apache License 2.0
8 stars 3 forks source link

Workflow Executions: Update Samples Option #544

Closed ericenns closed 5 months ago

ericenns commented 5 months ago

What does this PR do and why?

Describe in detail what your merge request does and why.

Adds in update_samples boolean to WorkflowExecution model, which when set to true will update the samples with metadata and files produced by the pipeline.

Updates NextflowComponent to include a allowed_to_update_samples boolean which will conditionally display the update_samples checkbox.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

As a User with maintainer or owner access for all of the samples

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Login as your preferred user
  2. Go to Projects Dashboard
  3. Click on a Project where you have analyst role
  4. Navigate to Samples page for the Project
  5. Select all samples and launch a pipeline
  6. Verify that update_samples checkbox is not present and that when executing with sapporo the pipeline completes successfully and does not get stuck in completing state, and that files and metadata are not written to the Samples
  7. Go to Projects Dashboard
  8. Click on a Project where you have owner or maintainer role
  9. Navigate to Samples page for the Project
  10. Select all samples and launch a pipeline
  11. Verify that update_samples checkbox is present and then select it, then when executing with sapporo the pipeline completes successfully and does not get stuck in completing state. And then verify that samples and metadata are written to the Samples.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

github-actions[bot] commented 5 months ago

Simplecov Report

Covered Threshold
91.91% 90%