phac-nml / irida-next

IRIDA Next
https://phac-nml.github.io/irida-next/
Apache License 2.0
8 stars 2 forks source link

WorkflowExecution: Change tags to jsonb #559

Closed ericenns closed 2 months ago

ericenns commented 2 months ago

What does this PR do and why?

Describe in detail what your merge request does and why.

Change tags attribute in WorkflowExecution to jsonb which matches GA4GH WES spec. Set default tags in WorklowExecutions::CreateService and remove tags from being settable by the user when submitting a workflow execution.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Run the server
  2. Run db migrations
  3. Navigate to a Project of your choice
  4. Select samples and submit a pipeline
  5. In rails console verify that tags are set.
    WorkflowExecution.last.tags

    Should look something like

    => {"createdBy"=>"admin@email.com"}

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

github-actions[bot] commented 2 months ago

Simplecov Report

Covered Threshold
91.81% 90%