phac-nml / irida-next

IRIDA Next
https://phac-nml.github.io/irida-next/
Apache License 2.0
8 stars 2 forks source link

Workflow Submission: Clean up dialog to use 1 form #561

Closed joshsadam closed 2 months ago

joshsadam commented 2 months ago

What does this PR do and why?

Describe in detail what your merge request does and why.

  1. Updated the workflow submission selection dialog to have only 1 horm instead of the number of submissions
  2. Added a loading indicator for when the form is submitted

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

Light image

Dark image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Add 10,000 samples to any project (either through rails console or through the seeds file) or
  2. Add a debugger command to line 57 of app/javascript/controllers/workflow_selection_controller.js, this will prevent the javascript before submitting the form so you can see the updated UI.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

github-actions[bot] commented 2 months ago

Simplecov Report

Covered Threshold
91.93% 90%