search

phac-nml / irida-next

IRIDA Next
https://phac-nml.github.io/irida-next/
Apache License 2.0
8 stars 2 forks source link

Workflow Execution: Change state to enum #563

Closed ChrisHuynh333 closed 2 months ago

ChrisHuynh333 commented 2 months ago

What does this PR do and why?

This PR changes workflow execution state from type string to enum. It also sets the state to running when the returned state is RUNNING and removes the state queued.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

  1. With workflow executions stored in your database, run bin/rails db:migrate. Ensure the migration is successful
  2. Through the UI, check the workflow executions page displays the expected states per WE
  3. Run a workflow execution containing a large number of samples. After sometime in the submitted state, ensure the WE state eventually changes to running. Afterwards, check that the WE completes.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

github-actions[bot] commented 2 months ago

Simplecov Report

Covered Threshold
91.84% 90%