phac-nml / irida-next

IRIDA Next
https://phac-nml.github.io/irida-next/
Apache License 2.0
8 stars 2 forks source link

Workflow Submission: Add namespace_id to workflow model #573

Closed joshsadam closed 2 months ago

joshsadam commented 2 months ago

What does this PR do and why?

Describe in detail what your merge request does and why.

Adds a parameter namespace_id to the workflow execution params.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

image

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Login and go to a project that you can execute a workflow from
  2. Open developer tools, go to the network tab and select persist logs
  3. Select a pipeline and submit
  4. In network tab, look at the logs and you should see something similar to: image

Check the rails console after executing a pipeline:

  1. Inspect the workflow you just ran: WorkflowExecution.last
  2. The namespace_id should be added to the workflow_execution

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

deepsidhu85 commented 2 months ago

@joshsadam you will also need to go through the service and controllers tests to update the params being passed to the create service for workflow executions

github-actions[bot] commented 2 months ago

Simplecov Report

Covered Threshold
92.31% 90%