phac-nml / irida-next

IRIDA Next
https://phac-nml.github.io/irida-next/
Apache License 2.0
8 stars 2 forks source link

GraphQL: CreateSample mutation not found Project error handling #593

Closed ericenns closed 2 months ago

ericenns commented 2 months ago

What does this PR do and why?

Describe in detail what your merge request does and why.

Updates CreateSample mutation to catch ActiveRecord::NotFound which would be caused by not found Project and responds accordingly with an appropriate error message.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Run tests and verify they pass

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

github-actions[bot] commented 2 months ago

Simplecov Report

Covered Threshold
92.08% 90%