search

phac-nml / irida-next

IRIDA Next
https://phac-nml.github.io/irida-next/
Apache License 2.0
8 stars 2 forks source link

Profiles controller refactor #597

Closed ericenns closed 2 months ago

ericenns commented 2 months ago

What does this PR do and why?

Describe in detail what your merge request does and why.

Refactor Profiles::PersonalAccessTokensController to remove unreachable code. Refactor Profiles::PreferencesController to ensure proper handling of invalid locale. Add in validation of locale to User model. Increase test coverage to 100% for all Profiles controllers.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Ensure tests pass locally

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

github-actions[bot] commented 2 months ago

Simplecov Report

Covered Threshold
92.39% 90%