search

phac-nml / irida-next

IRIDA Next
https://phac-nml.github.io/irida-next/
Apache License 2.0
8 stars 2 forks source link

refactor: Dialog Refactor #606

Closed joshsadam closed 3 weeks ago

joshsadam commented 1 month ago

What does this PR do and why?

Describe in detail what your merge request does and why.

Cleans up the viral dialog component by preventing it from touching the top and bottom of the window and adding a scroll to the contents, but keeps the header in place.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

image

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

This can be seen by going to lookbook and viewing the dialog with multiple section (http://localhost:3000/rails/lookbook/inspect/viral_dialog/with_multiple_sections)

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

github-actions[bot] commented 1 month ago

Simplecov Report

Covered Threshold
92.26% 90%
joshsadam commented 3 weeks ago

Not in scope