search

phac-nml / irida-next

IRIDA Next
https://phac-nml.github.io/irida-next/
Apache License 2.0
8 stars 2 forks source link

[DFCT0010059] Fixing user permissions for project workflow executions #618

Closed ksierks closed 1 month ago

ksierks commented 1 month ago

What does this PR do and why?

Fixing access to project workflow executions & analysis data exports. Only members with analyst access or higher should have access. Fixes #617.

Screenshots or screen recordings

A project member with a role less than an analyst should not be able to view a project workflow execution: image

A project member with a role of an analyst or higher should be able to view a project workflow execution & create a data export: image

How to set up and validate locally

  1. Create a new project.
  2. Select "Settings" -> "Automated Workflow Executions" from the sidebar menu.
  3. Click the "New automated workflow execution" button.
  4. Select a workflow and click the "Submit" button.
  5. Create a new sample within the project.
  6. Upload files within the new sample.
  7. Select "Workflow Executions" from the sidebar menu.
  8. Verify the new project workflow exists.
  9. Add members to the project and try logging in as them to make sure they can or cannot access the project workflow execution & create a data export based on their role.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

github-actions[bot] commented 1 month ago

Simplecov Report

Covered Threshold
92.32% 90%