search

phac-nml / irida-next

IRIDA Next
https://phac-nml.github.io/irida-next/
Apache License 2.0
8 stars 2 forks source link

GraphQL: Add isPuid query #625

Closed malchua closed 2 weeks ago

malchua commented 1 month ago

What does this PR do and why?

Describe in detail what your merge request does and why.

This PR adds in a new query named isPuid which returns True if the id given is in puid format. The query determines this from the id argument given.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Launch server and login as your preferred user
  2. Navigate to GraphiQL endpoint (e.g. http://localhost:3000/graphiql)
  3. Try the isPuid query using sample id 
    {
isPuid(id: "INXT_SAM_245HANDHG5")
}
  4. Try the isPuid query using sample id 
    {
isPuid(id: "INXT_SAM_245HANDHG865")
}
  5. Try querying an id for either a Sample, Attachment, Group, or Namespace::ProjectNamespace

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

malchua commented 1 month ago

Hi, just to update, I'm currently working on the failed tests right now. So no need to review yet.

github-actions[bot] commented 4 weeks ago

Simplecov Report

Covered Threshold
92.41% 90%