Closed ChrisHuynh333 closed 1 week ago
As discussed instead of having methods such as
new_*
lets try to move this into a deletions_controller for samples
A deletions_controller
has now been added to handle the dialog confirmation and destroy
actions for sample deletion
Covered | Threshold |
---|---|
92.54% | 90% |
What does this PR do and why?
This PR adds the ability to delete multiple samples from a project samples table.
In addition to this, other changes related to the changes required for this PR include:
infinite_scroll_controller
to use singular/plural forms based on number of selected samplesScreenshots or screen recordings
Screencast from 2024-06-19 09:36:05 AM.webm
Multi_status message:![image](https://github.com/phac-nml/irida-next/assets/82407232/0c206da8-6558-4be8-a4fe-290b5ac5f3b2)
Error:![image](https://github.com/phac-nml/irida-next/assets/82407232/c4e03812-39d3-40cc-8cbe-ec4d112bd152)
How to set up and validate locally
Deleting Multiple Samples:
Singular/Plural descriptions in sample dialogs:
Test single removal links while the item was selected with a checkbox
Test remaining checked samples after a removal still behave correctly
Remove
link to remove a sampleTest "Select All" checkbox and disabled button states after single removal
Remove
linkRemove
linkRepeat the above for the sample files
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.