phac-nml / irida-next

IRIDA Next
https://phac-nml.github.io/irida-next/
Apache License 2.0
8 stars 2 forks source link

[ENHC0010020] Delete multiple samples from project samples table #629

Closed ChrisHuynh333 closed 1 week ago

ChrisHuynh333 commented 4 weeks ago

What does this PR do and why?

This PR adds the ability to delete multiple samples from a project samples table.

In addition to this, other changes related to the changes required for this PR include:

Screenshots or screen recordings

Screencast from 2024-06-19 09:36:05 AM.webm

Multi_status message: image

Error: image

How to set up and validate locally

Deleting Multiple Samples:

  1. Navigate to a project samples table
  2. Select samples Check the following:
    • The correct number of selected samples appears in the dialog description
    • The correct samples are added to the table listing
  3. Delete the samples. Make sure the expected samples were deleted

Singular/Plural descriptions in sample dialogs:

  1. Select one and multiple samples and open the clone/transfer/delete sample dialogs. Make sure the description uses the singular and plural descriptions accordingly.

Test single removal links while the item was selected with a checkbox

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

ChrisHuynh333 commented 1 week ago

As discussed instead of having methods such as new_* lets try to move this into a deletions_controller for samples

A deletions_controller has now been added to handle the dialog confirmation and destroy actions for sample deletion

github-actions[bot] commented 1 week ago

Simplecov Report

Covered Threshold
92.54% 90%