search

phac-nml / irida-next

IRIDA Next
https://phac-nml.github.io/irida-next/
Apache License 2.0
8 stars 2 forks source link

Fix: Action links incorrectly enabled on empty table (DFCT0010080) #635

Closed ericenns closed 3 weeks ago

ericenns commented 3 weeks ago

What does this PR do and why?

Describe in detail what your merge request does and why.

This PR fixes the Action Links on Project and Group samples from being incorrectly enabled when No Samples associated with a Group or a Project.

This PR also refactors the Group and Project Samples tables.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

image

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Create an new Project without any Samples
  2. Navigate to the Samples page for the new Project
  3. Ensure that the action links are disabled and that an empty state message is shown
  4. Create a new Group
  5. Add the Project created above to the group
  6. Navigate to the Samples page for the new Group
  7. Ensure that the action links are disabled and that an empty state message is shown

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

github-actions[bot] commented 3 weeks ago

Simplecov Report

Covered Threshold
92.33% 90%