phac-nml / irida-next

IRIDA Next
https://phac-nml.github.io/irida-next/
Apache License 2.0
8 stars 2 forks source link

[ENHC0010033] List samples within clone dialog #640

Closed ksierks closed 2 weeks ago

ksierks commented 2 weeks ago

What does this PR do and why?

Fixes https://github.com/phac-nml/irida-next/issues/469.

Screenshots or screen recordings

image image

image image

image image

How to set up and validate locally

  1. Open a rails console and run the following:
project = Project.first

11.upto(10000) do |i|
  sample = Samples::CreateService.new(
    project.creator, project,
    { name: "#{project.namespace.parent.name}/#{project.name} Sample #{i}",
      description: "This is a description for sample #{project.namespace.parent.name}/#{project.name} Sample #{i}." 
    }
  ).execute
end
  1. Login as admin and navigate to http://localhost:3000/bacillus/bacillus-anthracis/outbreak-2022/-/samples.
  2. Select all the samples within the table.
  3. Click the Clone samples button.
  4. Verify the selected samples are displayed.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

github-actions[bot] commented 2 weeks ago

Simplecov Report

Covered Threshold
92.36% 90%