search

phac-nml / irida-next

IRIDA Next
https://phac-nml.github.io/irida-next/
Apache License 2.0
8 stars 2 forks source link

Front-end file type validation (ENHC0010035) #650

Closed joshsadam closed 1 week ago

joshsadam commented 1 week ago

What does this PR do and why?

Describe in detail what your merge request does and why.

Fixes #644 By adding validation when files are selected. This validation prevents the uploading of uncompressed sequencing files

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Create a new sample in any project you have permissions on.
  2. Attempt to upload a not compressed fasta or fastq file ==> it should not allow it
  3. Upload a compressed file (fasta.qz or fastq.qz) ==> should work

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

github-actions[bot] commented 1 week ago

Simplecov Report

Covered Threshold
92.58% 90%