search

phac-nml / irida-next

IRIDA Next
https://phac-nml.github.io/irida-next/
Apache License 2.0
8 stars 2 forks source link

Sample filtering when manually entering samples results in cursor moving to next sample entry if there is a pause (DFCT0010081) #651

Closed joshsadam closed 1 week ago

joshsadam commented 1 week ago

What does this PR do and why?

Describe in detail what your merge request does and why.

Fixes #647 Addresses issue when using lodash debounce to automatically create tags was confusing to users. In this update the user must add a coma. The final name does not need a coma, but will be converted into a tag when the user presses the submit button.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

image

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Go to any project that has samples.
  2. Open the filter by name or puid dialog
  3. Start typing sample names, and enter a comma, the name should be converted into a tag.
  4. Add another sample name and press enter, dialog should close, count on button should be updated to the correct amount, and table should update.
  5. Re-open the filter dialog and there should be a tag for each sample name given

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

github-actions[bot] commented 1 week ago

Simplecov Report

Covered Threshold
92.4% 90%