phac-nml / irida-next

IRIDA Next
https://phac-nml.github.io/irida-next/
Apache License 2.0
8 stars 2 forks source link

[DFCT0010082] Fix inconsistent menu highlighting #653

Open ChrisHuynh333 opened 1 week ago

ChrisHuynh333 commented 1 week ago

What does this PR do and why?

This PR fixes the sidebar menu highlighting to be more consistent, as well as incorporate menu highlighting in newer dropdown menus.

The fixes include:

Screenshots or screen recordings

image

How to set up and validate locally

  1. Navigate to projects and groups, select each item under Settings and ensure Settings remains open and the associated selection is highlighted
  2. Navigate to the user workflow executions index and show pages, and ensure Workflow Executions on the sidebar remains highlighted
  3. Because much of the def current_page calls through the codebase has been changed, click through the website and ensure the associated selections are highlighted on the sidebar

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

github-actions[bot] commented 23 hours ago

Simplecov Report

Covered Threshold
92.59% 90%