This PR fixes the sidebar menu highlighting to be more consistent, as well as incorporate menu highlighting in newer dropdown menus.
The fixes include:
Adds sidebar highlighting for user workflow executions index and show pages
In projects and groups, if an item on the sidebar is selected under the settings dropdown, the settings dropdown will now stay in the 'open' state and the associated selection will remain highlighted
Converted many def current_page calls in controllers to now use translations rather than the previous hardcoding as this would eventually cause issues once the application uses localization, as the sidebar selection/highlighting was dependent on these hardcoded out strings being equal to the sidebar translation. Ie: Members in French will probably not == 'members'
Screenshots or screen recordings
How to set up and validate locally
Navigate to projects and groups, select each item under Settings and ensure Settings remains open and the associated selection is highlighted
Navigate to the user workflow executions index and show pages, and ensure Workflow Executions on the sidebar remains highlighted
Because much of the def current_page calls through the codebase has been changed, click through the website and ensure the associated selections are highlighted on the sidebar
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
What does this PR do and why?
This PR fixes the sidebar menu highlighting to be more consistent, as well as incorporate menu highlighting in newer dropdown menus.
The fixes include:
index
andshow
pagesdef current_page
calls in controllers to now use translations rather than the previous hardcoding as this would eventually cause issues once the application uses localization, as the sidebar selection/highlighting was dependent on these hardcoded out strings being equal to the sidebar translation. Ie: Members in French will probably not == 'members'Screenshots or screen recordings
How to set up and validate locally
Settings
and ensureSettings
remains open and the associated selection is highlightedindex
andshow
pages, and ensureWorkflow Executions
on the sidebar remains highlighteddef current_page
calls through the codebase has been changed, click through the website and ensure the associated selections are highlighted on the sidebarPR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.