search

phac-nml / irida-next

IRIDA Next
https://phac-nml.github.io/irida-next/
Apache License 2.0
8 stars 2 forks source link

[ENHC0010020] Second part of Delete multiple samples to update import of utilities/form file #655

Closed deepsidhu85 closed 1 week ago

deepsidhu85 commented 1 week ago

What does this PR do and why?

Describe in detail what your merge request does and why.

This PR removes relative import of the app/javascript/utlilities/form directory and instead adds it to the importmap and is imported in js controllers with utlilities/form

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  1. Create a project, add 10 samples
  2. Try out the clone/export/tranfer/delete files
  3. Verify that the dialog loads correctly and lists the files that were selected
  4. Verify with the sample -> attachments as well
  5. Verify there are no console errors in the browser
github-actions[bot] commented 1 week ago

Simplecov Report

Covered Threshold
92.58% 90%