search

phac-nml / irida-next

IRIDA Next
https://phac-nml.github.io/irida-next/
Apache License 2.0
8 stars 2 forks source link

[ENHC0010037] Add member table sorting and searching #657

Open ksierks opened 1 week ago

ksierks commented 1 week ago

What does this PR do and why?

Added sorting and searching to group & project member tables. Fixes #641.

Screenshots or screen recordings

image image

How to set up and validate locally

  1. Navigate to a project or group members page.
  2. Use the search bar to filter by username.
  3. Click on a table header to sort the table.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

joshsadam commented 1 day ago

There is something wrong with the way the Access Level is being sorted, can you see if you can figure out what is causing it?

ksierks commented 1 day ago

There is something wrong with the way the Access Level is being sorted, can you see if you can figure out what is causing it?

Maybe I'm misunderstanding, but it's sorting the access level by enum value. Guest (10), Analyst (30), Maintainer (40), and Owner (50) is the sorted order. (least access to most access) I'm assuming the same thing for sorting dates. For example, we don't sort dates as January 18, July 23, June 16 but January 18, June 16, July 23.

joshsadam commented 1 day ago

I attempted to remove a user

There is something wrong with the way the Access Level is being sorted, can you see if you can figure out what is causing it?
 

Maybe I'm misunderstanding, but it's sorting the access level by enum value. Guest (10), Analyst (30), Maintainer (40), and Owner (50) is the sorted order. (least access to most access) I'm assuming the same thing for sorting dates. For example, we don't sort dates as January 18, July 23, June 16 but January 18, June 16, July 23.

Let's leave it the way it is; that is how GitLab does it. That date example you gave though is slightly different as users would know how dates are supposed to work, whereas access level enum is hidden. A general user does not know that (although I suppose since there are only 4 it is not that difficult to infer).

github-actions[bot] commented 6 hours ago

Simplecov Report

Covered Threshold
92.5% 90%