phac-nml / irida-sistr-results

Compile results generated from SISTR within IRIDA
Apache License 2.0
0 stars 1 forks source link

Feature/export sistr versions #4

Closed apetkau closed 6 years ago

apetkau commented 6 years ago

This adds a new command-line option --worklow-version to export SISTR results from only specific IRIDA/SISTR workflows. Fixes issue #3

This also adds a test suite and some unit tests.

peterk87 commented 6 years ago

Hey @apetkau this PR looks really good and thanks a lot for answering my questions. I definitely have a better understanding of what this tool does now.

If there's nothing else you want to add or change, I can go ahead and merge!

apetkau commented 6 years ago

Awesome, thanks @peterk87. Nope, nothing else to change for this PR. You can merge.

peterk87 commented 6 years ago

Hmm unfortunately, I can't

Only those with write access to this repository can merge pull requests.

apetkau commented 6 years ago

Woops, could you try again?