is pyqt still a required dependency ?

phac-nml / mob-suite

MOB-suite: Software tools for clustering, reconstruction and typing of plasmids from draft assemblies

Apache License 2.0

124 stars 33 forks source link

is pyqt still a required dependency ? #78

Closed EricDeveaud closed 2 years ago

EricDeveaud commented 3 years ago

Hello,

while building mob-suite/3.0.1 one can see PyQT5 as a dependency. is this one still required

none of the python files from mob-suite import pyqt ? as far as I understand pyqt was needed for TreeStyle that was removed on version 2.0.1 please ket me know

PS mob-suite/3.0.1 run smoothly after pyqt renmoveal in my basic tests and after removing pyqt from EGG-INFO/requires.txt

regards

Eric

kbessonov1984 commented 3 years ago

Hi Eric, Indeed, pyqt is not required anymore and was removed in conda recipe, but the library needs to be removed from the setup.py. Thank you for spotting it. The pyqt was previously required in previous MOB-Suite versions to render the taxonomy tree for the host range module.

jrober84 commented 2 years ago

The pyqt dependancy has been removed from the pending release of MOB-suite v. 3.1.0