phac-nml / sistr_cmd

SISTR (Salmonella In Silico Typing Resource) command-line tool
Apache License 2.0
25 stars 9 forks source link

Sistr cmd database update 2018 #33

Closed jrober84 closed 5 years ago

jrober84 commented 5 years ago

This update resolves the following issues through a combination of code changes, biomarker database updates, and cgMLST database updates:

https://github.com/peterk87/sistr_cmd/issues/32 https://github.com/peterk87/sistr_cmd/issues/31 https://github.com/peterk87/sistr_cmd/issues/28 https://github.com/peterk87/sistr_cmd/issues/27

SISTR databases will now be downloaded on the first run since they cannot be stored in github due to size constraints

peterk87 commented 5 years ago

Hi @jrober84 @jamespocalypse

It looks like the entire codebase has been duplicated under <root>/sistr - is this intentional?

jrober84 commented 5 years ago

That was incorrectly duplicated, thank you for removing it @peterk87

apetkau commented 5 years ago

I am closing this since the proper pull request is https://github.com/phac-nml/sistr_cmd/pull/35.