Closed emarinier closed 1 year ago
Thanks so much @emarinier . This looks great 😄. I still have to test out by running staramr on real data.
1. In addition to adding the unit test cases, could you also add an integration test case. Specifically, adding an `assertEquals` statement to at least one of the lookups of mutations for our test data in our integration test cases?
I believe I've added a couple tests to check this now.
I ran the test suite on my machine and it is passing. Something is wrong with the GitHub actions tests that we can revisit later.
Two additional comments:
detailed_summary.tsv
output?Actually, re-thinking this, let's leave Notes out of detailed_summary.tsv
. Sorry about that.
Changed Notes
to CGE Notes
resfinder.tsv
andpointfinder.tsv
outputs now have aNotes
column that are derived from the CGE drug key database andphenotypes.txt
databases (respectively) for each mutation identified.