phac-nml / staramr

Scans genome contigs against the ResFinder, PlasmidFinder, and PointFinder databases.
Apache License 2.0
120 stars 26 forks source link

Testing gyrA Duplicate in E. coli #192

Closed emarinier closed 1 year ago

emarinier commented 1 year ago

Addressing #174

It seems like the exception used to be thrown in StarAMR 0.8.0 but (probably) not in 0.9.0. I wrote a test to ensure this specific case is being handled as expected, and it appears we are already merging duplicate entries as expected on the development branch.

This issue might already be resolved in 0.9.0 (unconfirmed), but development looks to have it resolved already. I also removed an import of the previous exception, as it is no longer thrown by PointfinderDatabaseInfo.