phac-nml / staramr

Scans genome contigs against the ResFinder, PlasmidFinder, and PointFinder databases.
Apache License 2.0
115 stars 26 forks source link

Fixed detailed_summary.tsv output format #64

Closed jennifertran closed 5 years ago

jennifertran commented 5 years ago

Based on Issue #63

Problem

In the detailed_summary.tsv file that's generated from staramr, some of the columns contained entries that were not properly rounded leaving values like 99.899999999 and the Start and End columns were displayed in decimals rather than integers

Solution

Determine what's causing this error and round the the %Identity and %Overlap to the nearest 2 decimal places as well as attempt to format the Start and End columns as an integer.

Implementation

  1. Add two parameters in the negative entries dataframe that includes Start and End columns.
  2. Round each dataframe to the nearest decimal places that has the Start and End columns.

Testing

Ran staramr through 50 test .fna files to see if the detailed_summary.tsv were the expected output

apetkau commented 5 years ago

Thanks so much. Merging.