search

phacility / xhprof

XHProf is a function-level hierarchical profiler for PHP and has a simple HTML based user interface.
http://pecl.php.net/package/xhprof
Apache License 2.0
2.6k stars 925 forks source link

XHProf PHP-extension - added Win(NT/32) compatibility #1

Closed benjamin-carl closed 11 years ago

benjamin-carl commented 13 years ago

Hi Scott, hi Facebook-Team,

first of all - Thanks for this really good piece of software - i like it very much cause it saved my day a lot of times!

So i did some slightly changes to the source-files of the XHProf PHP-extension to make it compilable on Windows platforms. I also did some minor changes to some parts of the code and removed some unreferenced variables to remove compiler warnings.

I hope you like the changes and the added compatibility and looking forward to the intgeration of my changes into the facebook/xhprof repo with great anticipation.

I also hope that the sources will still compile on your system(s) and that you now can remove the note: "A windows port hasn't been implemented yet." at http://mirror.facebook.net/facebook/xhprof/doc.html ;)

best regards and greetings from Germany Benjamin Carl

billf commented 12 years ago

if there's any chance of this getting pulled in, the win32 portions and the database backing code needs to be separated out.

for the database backed storage code, the "pick a XHProfRuns_Default based on which file you include" needs to go away.

pavelkouril commented 12 years ago

Will this ever be merged in? Or will there be support for windows directly from FB?

Rarst commented 11 years ago

This pull request seems ruined due to age and master-master mapping, but I'd still like to see some of code from that fork make it in. I am using fixes for callgraphs from there for a while already.

PS mostly interested in web interface parts, since I procured ready-made compiled binary for win, rather than struggle with compiling it myself :)

benjamin-carl commented 11 years ago

This pull request is no longer interesting due its age and so i send a new fresh one and closed this.