search

phacility / xhprof

XHProf is a function-level hierarchical profiler for PHP and has a simple HTML based user interface.
http://pecl.php.net/package/xhprof
Apache License 2.0
2.6k stars 925 forks source link

php-5.5.8 Segmentation fault xhprof.c #33

Closed kovalenko closed 10 years ago

kovalenko commented 10 years ago

php-5.5.8 Segmentation fault details: (gdb) f 0

0 hp_execute_internal (execute_data=0x7fffffffa600, fci=0x7fffffffa780, ret=1) at /opt/xhprof/extension/xhprof.c:1708

1708 temp_variable retvar = &EX_T(opline->result.var); (gdb) print opline $1 = (zend_op ) 0x0

bitraft commented 10 years ago

this patch working on my mac osx 10.8 with php55.

PHPGangsta commented 10 years ago

I also have this segmentation fault, in exactly the same line 1708

I'm using PHP 5.5.3-1ubuntu2.1 from current Ubuntu 13.10

I would be nice if it could be merged and a new PECL package could be released.

(gdb) bt

0 hp_execute_internal (execute_data=0x7fffb5ed7bd0, fci=0x7fffb5ed7d50, ret=1) at /tmp/pear/temp/xhprof/extension/xhprof.c:1708

1 0x00007f73e727c34b in zend_call_function () from /usr/lib/apache2/modules/libphp5.so

2 0x00007f73e727ca2c in zend_lookup_class_ex () from /usr/lib/apache2/modules/libphp5.so

3 0x00007f73e727d192 in zend_fetch_class_by_name () from /usr/lib/apache2/modules/libphp5.so

4 0x00007f73e72c1a09 in ?? () from /usr/lib/apache2/modules/libphp5.so

5 0x00007f73e72b3988 in execute_ex () from /usr/lib/apache2/modules/libphp5.so

6 0x00007f73da64dec0 in hp_execute_ex (execute_data=0x7f73ec383120) at /tmp/pear/temp/xhprof/extension/xhprof.c:1664

......

cabello commented 10 years ago

We just applied this patch and built our xhprof package, this one is working well for us. Many thanks!

epriestley commented 10 years ago

I hit what is presumably the same issue (consistent segfault under PHP 5.5.8 on OS X); this also fixed it for me.

billf commented 10 years ago

@kovalenko can you sign the contributor agreement at https://code.facebook.com/cla

wimleers commented 10 years ago

Does anybody know how to contact @kovalenko, so that this PR gets unblocked?

epriestley commented 10 years ago

I've generated a similar patch here:

https://secure.phabricator.com/D10374 https://secure.phabricator.com/D10375

These don't have a CLA issue and should land once they're reviewed.