search

phacks / notion-ruby-client

A Ruby client for the Notion API
MIT License
117 stars 25 forks source link

update Notion-Version to 2022-02-22 #16

Closed hkob closed 2 years ago

hkob commented 2 years ago

Hello, thank you very much for developing the gem for Notion's API. I use your notion-ruby-client library in my notion-ruby-mapping project. I want to update my some PropertyClass object for Notion-Version 2022-02-22.

Your implementation code is almost unaffected by this change, but some of the test code needed to be changed. So I changed API responses (*.yml) and corresponding RSpec verification values. Moreover, List database endpoint was deprecated from Notion-Version 2022-02-22, so I removed the corresponding implementation and RSpec.

However, the "Retrieve a page property item" added this Notion-Version is not additionally implemented.

phacks commented 2 years ago

Thanks for your PR! I somehow missed the notification and just saw it. I’ll be reviewing it in the next few days!

hkob commented 2 years ago

I'm sorry that I forgot to fetch the original repository. This patch was merged the head of the original repository.