Non-empty TDigest - Githubissues

phadej / tdigest

On-line accumulation of rank-based statistics such as quantiles and trimmed means

30 stars 7 forks source link

Non-empty TDigest #12

Closed maoe closed 7 years ago

maoe commented 7 years ago

Does it make sense to implement an API for non-empty TDigest so quantile returns a plain Double rather than Maybe Double, and (minimum|maximum)Value never return infinity?

The non-empty TDigest wouldn't have the Monoid instance and also tdigest would look like either of

tdigest :: (KnownNat comp) => NonEmpty Double -> TDigest comp or
tdigest :: (Foldable f, KnownNat comp) => f Double -> Maybe (TDigest comp).

phadej commented 7 years ago

I wouldn't change the current interface for now. Adding Data.TDigest.NonEmpty makes sense (and refactoring Postprocess to be re-usable for both).

phadej commented 7 years ago

this exists in 0.1

maoe commented 7 years ago

Thank you!