phaibin / MoliView

It's a user feedback project for MoliView
1 stars 0 forks source link

Directory looping enhancements #21

Closed mcackay closed 3 months ago

mcackay commented 3 months ago

Would it be possible to add:

phaibin commented 3 months ago

Yes, this is reasonable.

newkind commented 3 months ago

@phaibin I think that the messages should be possible to be disabled. To be honest I personally don't like the popup window that appears when I reach the last image. Can this be a toggle in the settings please? :)

mcackay commented 3 months ago

@phaibin Thanks again for taking on this idea. The looping seems to be working well.

Re: Looping Overlay

I can see overlays appearing when you reach the first and last image: "Last One! Will be back to the first one".

And when you use the Home or End shortcuts, you see the overlay saying they're at the end, even though that was the user's intentional action.

Taking into account @newkind's feedback, I would suggest a few tweaks to reduce the frequency of the messages and make them more relevant:

... that way, if someone has 'Loop Images' disabled, they'll never see the overlay.

I've also note that the overlay is only showing for as long as you have the first/final image is showing on screen. If you are quickly scanning the directory, it may only show up for a 100ms or so -- and I'm can be very easy to miss. Suggest:

newkind commented 3 months ago

These tweak suggestions seem nice @mcackay, however I just don't want these overlays at all - doesn't matter if the loop is enabled or disabled. For me they are distracting and unneeded, that's why I think you should be able to have a configuration option to enable or disable them entirely.

If someone prefers to use them and has an usage for them - like you - they can enable them, if someone doesn't need them - just disable them in the settings. This makes everyone happy and allow them to set the Moli the way they want it :)

phaibin commented 3 months ago

@mcackay That's better.

Actually I don't like the message either.😂 So I'll add a switch to this function and it will default to off. Sorry about that.

phaibin commented 3 months ago

@mcackay @newkind Please check if the prompt is OK.

mcackay commented 3 months ago

Working great for me thanks :)

newkind commented 3 months ago

Looks good, I love that its disabled by default :) Also I think that you did improve the design nicely for people who will use it. Awesome job!