search

phaistonian / MyExtensions

Are you an extensions developer? Keep track of your Chrome extensions. Be notified for new comments, ratings and more!
https://chrome.google.com/webstore/detail/igejgfmbjjjjplnnlgnbejpkpdajkblm
52 stars 24 forks source link

Everything is back on track! #19

Closed brisssou closed 12 years ago

brisssou commented 12 years ago

The extension is working with those changes.

neocotic commented 12 years ago

As discussed, could you please change the regular expression to the following;

/<script type="text\/javascript" src="\/webstore\/static\/(\d*)\/wall\/js\/webstore[^"]*"><\/script>/i

This should be safer and less prone to problems in the future. I've tested this locally and it works for English at least. Could you make this change and test it works for a non-English version?

neocotic commented 12 years ago

This looks good to me. I don't know if he'll release 0.9.5.2 so soon but I recommend this is accepted if it fixes a future problem for international users.

However, it's not too urgent right now as I updated the fallback pv today so it will be valid until Google change it again.

brisssou commented 12 years ago

And we're back :)

pv was updated on the store, and cannot be guessed using a l10n agnostic url.

May you accept this pull request, it is likely to work again.

brisssou commented 12 years ago

I tested the extension with the code, and it worked like a charm.

neocotic commented 12 years ago

OK, I've tested this on the international page (standard English) and it works. I'm not sure why you replaced [^"]* with .*? but if it still works so be it.

@phaistonian Would you be able to create a release soon as without this change most non-English users will not be able to use the extension.