search

phaistonian / MyExtensions

Are you an extensions developer? Keep track of your Chrome extensions. Be notified for new comments, ratings and more!
https://chrome.google.com/webstore/detail/igejgfmbjjjjplnnlgnbejpkpdajkblm
52 stars 24 forks source link

Manifest Version 2 Support #24

Closed neocotic closed 12 years ago

neocotic commented 12 years ago

Updates the manifest to version 2 and makes the extension CSP-compatible as version 1 extensions will soon no longer be supported.

This involves quite a lot of work and I've tested it all and it currently works just as well as the current (live) version. However, it might be worth reading over my commit comments before accepting this pull request as the changes are so wide spread.

I tried to only make the required changes but, as you'll see, I managed to make a few other fixes, tweaks and enhancements - I hope you don't mind.

neocotic commented 12 years ago

I'm going to make some changes to the permissions and CSP as I think I've changed somethings that maybe didn't need changing.

neocotic commented 12 years ago

I've made the necessary changes and I'm much happier with the results. I don't see any caveats anymore as there are no additional/modified permissions and we can just use the default CSP.

neocotic commented 12 years ago

@phaistonian Any chance of this getting implemented soon?

This is quite important as extensions using manifest version 1 will not be allowed to be updated until they implement manifest version 2. This will happen in September for Beta and November for Stable releases.

phaistonian commented 12 years ago

Hey there.

To be honest I have no idea what this actually means and what I should do about it :)

I 'd be more than happy to push any changes to the manifest file to the store though --- in case you care to do them.

If this is requires me to do something from my part, please elaborate and I will do so.

Thank you.

neocotic commented 12 years ago

This update includes all the necessary changes to be compatible with manifest version 2, so all that is required is for this pull request to be merged in and then just update the extension on the web store as you would normally.

I just think it's better doing all this now so, if we need to fix something standard (i.e. web store changed its infrastructure again), we won't have to do all this work as well. This push doesn't fix any bugs (exception for changing the URL of the extensions page - as Chrome has changed it again) , so only makes MyExtensions future proof.

I just added all those comments in case you, or someone else, was wanting a detailed explanation of the changes. I've added plenty of links though if you want to look into the reason for this more.

phaistonian commented 12 years ago

Oh, great.

Merging + updating now.

Thank you :)