phaistonian / MyExtensions

Are you an extensions developer? Keep track of your Chrome extensions. Be notified for new comments, ratings and more!
https://chrome.google.com/webstore/detail/igejgfmbjjjjplnnlgnbejpkpdajkblm
52 stars 24 forks source link

Empty popup #30

Closed pepri closed 10 years ago

pepri commented 10 years ago

In Chrome 35+, the popup action has no content.

The exception is: Uncaught ReferenceError: webkitNotifications is not defined

The problem is in js.js:2149

The webkitNotifications should be accessed using the global object (add the "window."): if(!( window.webkitNotifications && webkitNotifications.createNotification)) {

Thanks for your extension.

Edit: Actually, the proper fix would be to change it to use Notification object instead of webkitNotifications.

pepri commented 10 years ago

OscarDeDios, thanks for fixing this. Awesome!

OscarDeDios commented 10 years ago

You are wellcome @pepri . I like a lot this extension, to see the statistics of my extensions is one of the first things I do every morning I needed fixed quikly ;-)

neocotic commented 10 years ago

Am I the only one still seeing this issue? I have the latest version and I'm seeing nothing in the popup and the options page is broken. Both have the following errors in the console:

Failed to load resource: net::ERR_FILE_NOT_FOUND chrome-extension://igejgfmbjjjjplnnlgnbejpkpdajkblm/js/core-lite.js
Failed to load resource: net::ERR_FILE_NOT_FOUND chrome-extension://igejgfmbjjjjplnnlgnbejpkpdajkblm/js/js.js
Failed to load resource: net::ERR_FILE_NOT_FOUND chrome-extension://igejgfmbjjjjplnnlgnbejpkpdajkblm/js/background.js

Anyone got any ideas. It looks to me like the update package was corrupt or something.

phaistonian commented 10 years ago

That's weird.

Repacked and resubmitted.

Hopefully this will fix it. If not, we take it from there.

neocotic commented 10 years ago

Sorry for the late response. I can't test on the machine I originally noticed this on right now, but it appears to work fine on my work laptop, meaning that the latest version is fixed. If it's still broken on my home machine, I'll reinstall the extension.

Thanks for fixing it.

phaistonian commented 10 years ago

Thank you for reporting :-)