phalcon / cphalcon

High performance, full-stack PHP framework delivered as a C extension.
https://phalcon.io
BSD 3-Clause "New" or "Revised" License
10.76k stars 1.96k forks source link

[NFR]: Refactor short syntax get/set for properties #16102

Closed niden closed 1 year ago

niden commented 1 year ago

Refactor classes to have full getter / setter methods instead of the shorthand ones.

Refactor this

/**
 * @var string
 */
property one "" { get, set };

to this

public function getOne() -> string
{
    return this->one;
}

public function setOne(string value) -> void
{
    let this->one = value;
}
niden commented 1 year ago

Resolved in https://github.com/phalcon/cphalcon/pull/16103