phalcon / cphalcon

High performance, full-stack PHP framework delivered as a C extension.
https://phalcon.io
BSD 3-Clause "New" or "Revised" License
10.79k stars 1.96k forks source link

Phalcon 5.7.0 Release Reports 5.6.2 as Internal Version Number #16597

Closed kgrammer closed 4 months ago

kgrammer commented 6 months ago

Describe the bug After issuing pecl command to update to Phalcon 5.7.0, Phalcon's internal version is still reported as the last release, which was 5.6.2.

To Reproduce Use pecl to update to the latest 5.7.0 release. Issue "php -i" and you will see Phalcon 5.7.0 listed as the installed version.

Issue php -r "echo (new \Phalcon\Support\Version())->get();" and you will see version 5.6.2 returned.

In the code, the following returns "5.6.2".

    $phalcon_version = new \Phalcon\Support\Version();
    $dashboard['phalcon_version'] = $phalcon_version->get();                    # Get the version of Phalcon we are running

Expected behavior The expected behavior is for the internal Phalcon version returned to be "5.7.0".

Details

Additional context Nothing more to add.

fln commented 6 months ago

Can confirm the issue:

# php -i | grep -A 2 'phalcon =>'
phalcon => enabled
Author => Phalcon Team and contributors
Version => 5.7.0

But:

# php -r "echo (new Phalcon\Support\Version())->get();"
5.6.2
fln commented 6 months ago

Version is hard-coded in PHP_METHOD(Phalcon_Support_Version, getVersion):

https://github.com/phalcon/cphalcon/blob/master/ext/phalcon/support/version.zep.c#L101

niden commented 6 months ago

Sorry about that guys. I forgot to change the version in the Version.zep.

I just pushed a commit on 5.0.x that solves this.

kgrammer commented 6 months ago

@niden, I just installed again from pecl and the internal version is still returning 5.6.2.

niden commented 6 months ago

@niden, I just installed again from pecl and the internal version is still returning 5.6.2.

Yes the internal for now will still report 5.6.2. If you install from the 5.0.x branch it will show the correct one.

I will be releasing a new version this week coming so this will be resolved in pecl also.

samgiety commented 4 months ago

I'm still getting the old version (5.6.2) with the pecl install phalcon(-5.7.0).

niden commented 4 months ago

This has been resolved with the new release.