[BUG]: Fatal error on route group getHostname

phalcon / cphalcon

High performance, full-stack PHP framework delivered as a C extension.

https://phalcon.io

BSD 3-Clause "New" or "Revised" License

10.79k stars 1.96k forks source link

[BUG]: Fatal error on route group getHostname #16601

Closed oleghind closed 5 months ago

oleghind commented 5 months ago

There is a fatal error when using Route Group without hostname restriction. PHP Fatal error: Phalcon\Mvc\Router\Group::getHostname(): Return value must be of type string, null returned in Unknown on line 0

I suggest changing functions return type to string | null instead of just string.

niden commented 5 months ago

Resolved in https://github.com/phalcon/cphalcon/pull/16602

Thank you @oleghind