search

phalcon / migrations

Generate or migrate database changes via migrations.
https://docs.phalcon.io/latest/en/db-migrations
BSD 3-Clause "New" or "Revised" License
27 stars 23 forks source link

Decimal and Float Column size is not saving #92

Closed jdubreville closed 3 years ago

jdubreville commented 4 years ago

When generating a migration the size of a decimal and float column is not being saved as it was in previous versions. This prevents the migration from being pushed forward and you will get an error that Float(M,D) or Decimal(M,D) and that M must always be >= D.

jdubreville commented 4 years ago

So I dug in a little more and Float and Decimal are in the noSizeTypes list which I don't think this is correct for MySql as the size is the precision of the number being stored. I don't mind making a pull request for this but it would need to update back to 1.2 and up.

Jeckerson commented 4 years ago

@jdubreville Could you make an PR please? Or example little bit better with some example.