jenovateurs commented 4 years ago

Hello team! I added the launcher.bat file that missing for Windows. I changed / to DIRECTORY_SEPARATOR. In the launcher.bat files, I changed the name PATH to CURRENT_PATH. Windows use PATH to know where php is locate so it's very important to not override this variable. I added a changelog, it will be useful when release a new version.

Type: bug fix
Link to issue: #1440

In raising this pull request, I confirm the following (please check boxes):

[x] I have read and understood the Contributing Guidelines
[x] I have checked that another pull request for this purpose does not exist
[ ] I wrote some tests for this PR

Thanks for the review :-)

codecov[bot] commented 4 years ago

Codecov Report

Merging #1441 into 4.0.x will increase coverage by 0.12%. The diff coverage is 0%.

@@            Coverage Diff             @@
##             4.0.x   #1441      +/-   ##
==========================================
+ Coverage     3.55%   3.67%   +0.12%     
  Complexity    1099    1099              
==========================================
  Files          111     111              
  Lines         4756    4762       +6     
==========================================
+ Hits           169     175       +6     
  Misses        4587    4587

Impacted Files	Coverage Δ	Complexity Δ
src/Builder/Project/Cli.php	`0% <0%> (ø)`	`7 <0> (ø)`	:arrow_down:
src/Script/Color.php	`35.89% <0%> (+15.38%)`	`15% <0%> (ø)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 40e8e99...b9a6ec2. Read the comment docs.

jenovateurs commented 4 years ago

Thanks @Jeckerson and @sergeyklay for your reviews :-).

phalcon / phalcon-devtools

fix: added cli/launcher.bat and add changelog #1440 #1441

Codecov Report