Closed jenovateurs closed 4 years ago
Still in progress...
Merging #1446 into 4.0.x will not change coverage by
%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## 4.0.x #1446 +/- ##
=====================================
Coverage 3.42% 3.42%
=====================================
Files 111 111
Lines 5108 5108
=====================================
Hits 175 175
Misses 4933 4933
I'm done changing things in this PR. You can find the result of GitHub CI here : https://github.com/les-enovateurs/phalcon-devtools/runs/565050607?check_suite_focus=true About PR Quality, is it possible to ignore it ? There are old problems like $I is too short, ... Thanks for your reviews. :-)
I think that good . Need second review; What do you think @Jeckerson ?
Hello team!
In raising this pull request, I confirm the following (please check boxes):
A lot of work has been done. GitHub Actions works on my fork but I didn't try with Travis. I think, I will get some errors that I will solve. I added two groups one for mysql, second for pgsql like we can found in cphalcon project. About CODECOV, I don't have the CODECOV_TOKEN, if someone can add it on the project ;-).
Thanks