phalcon / phalcon-devtools

Phalcon Developer Tools

https://docs.phalcon.io/latest/en/devtools

Other

1.33k stars 630 forks source link

Fix error Psalm - Calling empty on a boolean value is almost certainly unintended #1449

Closed jenovateurs closed 4 years ago

jenovateurs commented 4 years ago

Hello team!

I fixed some errors that Psalm found. And I resolve the problem with empty - Calling empty on a boolean value is almost certainly unintended

Type: bug fix
Link to issue:

In raising this pull request, I confirm the following (please check boxes):

[x] I have read and understood the Contributing Guidelines
[x] I have checked that another pull request for this purpose does not exist
[x] I wrote some tests for this PR

Thanks

codecov[bot] commented 4 years ago

Codecov Report

Merging #1449 into 4.0.x will increase coverage by 0.11%. The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           4.0.x   #1449      +/-   ##
========================================
+ Coverage   3.30%   3.42%   +0.11%     
========================================
  Files        111     111              
  Lines       5108    5114       +6     
========================================
+ Hits         169     175       +6     
  Misses      4939    4939

jenovateurs commented 4 years ago

I don't know why Github CI triggered errors ? In my fork project, there is no issue : https://github.com/les-enovateurs/phalcon-devtools/actions/runs/75916762