search

phalcon / phalcon-devtools

Phalcon Developer Tools
https://docs.phalcon.io/latest/en/devtools
Other
1.33k stars 630 forks source link

Upgrade lucas/phpdotenv dependency to v4 #1460

Closed ghost closed 3 years ago

ghost commented 4 years ago

Expected and Actual Behavior

Describe what you are trying to achieve and what goes wrong.

I am currently using lucas/phpdotenv in my project and it is at version 4. However if I want to install phalcon-devtools, it requires me downgrade the phpdotenv in my project to 3.6.

Provide output if related

image

I would be able to make a pull request if you also feel like this can be addressed.

quinnjr commented 4 years ago

Taking a cursory look over the library, I can't find any actual invocation of Dotenv. The only uses of environment variables are through getenv().

Perhaps the requirement should be dropped altogether since Dotenv v5 is also available?

Edit: In general, it looks like the versions of multiple requirements need to be updated.

misantron commented 3 years ago

Any updates here? Will be great to update lucas/phpdotenv to actual version.

Jeckerson commented 3 years ago

Will be released in next version.