[IDEA] ERROR: could not find driver - Should be more explained

phalcon / phalcon-devtools

Phalcon Developer Tools

https://docs.phalcon.io/latest/en/devtools

Other

1.33k stars 630 forks source link

[IDEA] ERROR: could not find driver - Should be more explained #1479

Closed yassinrais closed 3 years ago

yassinrais commented 3 years ago

When a Database Driver Extension is missed

its should say ERROR: could not find php extension driver postgress

because its take more time to understand that the extension who is missed and not an issue about the name of adapater

Thanks :D !

BeMySlaveDarlin commented 3 years ago

This is base message related to PHP core \Exception

} catch (Exception $e) {
    fwrite(STDERR, 'ERROR: ' . $e->getMessage() . PHP_EOL);
    exit(1);
}

As its created outside of phalcon, we cannot properly customize message. Available options is:

We can change message to DATABASE ERROR: could not find driver, catching directly PDOException
We can add trace of exception after message to output

Jeckerson commented 3 years ago

@BeMySlaveDarlin Ok, we will return to this in next major version.

Ultimater commented 3 years ago

Devtools provides tools which can save a developer a few minutes. But a vague error like this will send a developer on a totally avoidable quest trying to figure out what's wrong. In the spirit of devtools, where we want to save people time, I believe this issue is very important to fix.

I'll work on releasing a fix for this on 3.4.x, 4.0.x, and 4.1.x

Ultimater commented 3 years ago

This is fixed in v3.4.14, v4.0.8 and v4.1.1