phalcon / phalcon-devtools

Phalcon Developer Tools

https://docs.phalcon.io/latest/en/devtools

Other

1.33k stars 630 forks source link

Fix/issue 1426 windows config path matching #1487

Closed BeMySlaveDarlin closed 3 years ago

BeMySlaveDarlin commented 3 years ago

Hello!

Type: bug fix
Link to issue: #1426

In raising this pull request, I confirm the following (please check boxes):

[x] I have read and understood the Contributing Guidelines
[x] I have checked that another pull request for this purpose does not exist
[ ] I wrote some tests for this PR

Small description of change: Regex matching is overhead in just searching filename in path string. Which causes platform dependent issues. Replaced preg_match in config file comparison by strpos.

Thanks

codecov[bot] commented 3 years ago

Codecov Report

Merging #1487 (b8ddd9c) into 4.0.x (e65d38c) will increase coverage by 0.00%. The diff coverage is 0.00%.

@@          Coverage Diff          @@
##           4.0.x   #1487   +/-   ##
=====================================
  Coverage   3.16%   3.17%           
=====================================
  Files        111     111           
  Lines       5112    5110    -2     
=====================================
  Hits         162     162           
+ Misses      4950    4948    -2