phalcon / phalcon-devtools

Phalcon Developer Tools
https://docs.phalcon.io/latest/en/devtools
Other
1.33k stars 629 forks source link

Fix #1508 devtools version showing phalcon version instead for 4.0.x #1512

Closed Ultimater closed 3 years ago

Ultimater commented 3 years ago

Hello!

In raising this pull request, I confirm the following (please check boxes):

Small description of change:

4.0.x uses _getVersion() instead of getVersion() when extending Phacon\Version, this results in devtools reporting back the wrong version of devtools back to the user as though devtools and phalcon have the same version when they really have different versions.

Thanks

codecov[bot] commented 3 years ago

Codecov Report

Merging #1512 (af6158e) into 4.0.x (d6f7721) will not change coverage. The diff coverage is 0.00%.

@@          Coverage Diff          @@
##           4.0.x   #1512   +/-   ##
=====================================
  Coverage   3.29%   3.29%           
=====================================
  Files        112     112           
  Lines       5103    5103           
=====================================
  Hits         168     168           
  Misses      4935    4935