search

phalcon / phalcon-devtools

Phalcon Developer Tools
https://docs.phalcon.io/latest/en/devtools
Other
1.33k stars 629 forks source link

5.0.1 - Add Support for Phalcon V5 and PHP 8 #1532

Open jesusfreak3 opened 1 year ago

jesusfreak3 commented 1 year ago

Hello!

In raising this pull request, I confirm the following (please check boxes):

Small description of change:

Updated dev tools to work with Phalcon V5.0.1 and PHP 8.0/8.11. Updated to use latest Phalcon migration V3 which includes Phalcon 5 and PHP 8 suport

Thanks

niden commented 1 year ago

@Jeckerson will check this more thoroughly.

First impressions:

Finally tests setup for Github actions fails - composer issue.

Thank you for the contribution but this needs a bit more work.

jesusfreak3 commented 1 year ago

@niden thanks for this, ill take a look. That was an accidental add of the composer.phar file, was working on it at 1:00am. The listed files you mentioned did not exist when I forked from Phalcon dev tools, ill double check what happened there, and will check the composer issue. Maybe I forgot to commit an update as composer update/install works fine locally and with my projects. Thanks for reviewing this.

jesusfreak3 commented 1 year ago

@niden i see what it is, i have everything running on php8.1, and not php8.0 so composer is failing here as config shows php8.0. I will rework this so php8.0 works as well since its still supported with security updates till end of this year.

jesusfreak3 commented 1 year ago

@niden ok, i see what happened.. I forked off 4.3.0 as I thought it was the latest stable, and that branch is missing those files you mentioned. I assume 4.2.0 is the latest stable version? It does not match master. Just trying to understand which branch I should have worked off of... 5.0.0 matches master, but its missing changes from 4.2.0, but 5.0.0 works less good then 4.2.0 in php 8. Though 4.2.0 has slight changes to make the version work for 5.0.0 but nothing else.. Ill re do this from master, blah...

jesusfreak3 commented 1 year ago

@niden is 4.3.x /v4.3.0 approved and legit? There is a lot of changes there adding a new dev tool method called task, updating some PHP standards with public const etc.. but also included all the deleting of the docker files and make files. Should I still use this, but just re add back all the deleted tests, make, docker etc? Let me know which direction I should go here so I can get this worked out.

jesusfreak3 commented 1 year ago

@niden or @Jeckerson any input here? I would like to get this finalized. I am already using this branch in my project so that I can still use dev tools and phalcon 5.0.1 and php 8.0/1 but would like to complete this. thanks

rudiservo commented 11 months ago

hey @jesusfreak3, you should have made it from the 5.0.x branch, but if it matches the is should be ok in terms of commit signitures.

Let's try and fix this so we can move forward, you have done a lot of work, that is commendable, but it's really complicated to understand why in the middle of so many commits and with little to no explanation why the changes where made.

Some of these commits can be squashed, other would be nice to have their own PR so that we can understand what they fix.

For example added support for php8 and phalcon 5 does it require to delete files in templates? The tests for Snippet.php, is it required or it's just refactoring code?

Like Niden said, it needs some work, but it is fixable, can you do that? Make a copy of the branch before you start messing with it.