bugfix/invalid_config_call Fixed the way Config class was called

phalcon / phalcon-devtools

Phalcon Developer Tools

https://docs.phalcon.io/latest/en/devtools

Other

1.33k stars 629 forks source link

bugfix/invalid_config_call Fixed the way Config class was called #1540

Open abiral opened 11 months ago

abiral commented 11 months ago

Hello!

Type: bug fix
Link to issue: https://github.com/phalcon/phalcon-devtools/issues/1526

In raising this pull request, I confirm the following (please check boxes):

[x] I have read and understood the Contributing Guidelines
[x] I have checked that another pull request for this purpose does not exist
[ ] I wrote some tests for this PR

The PR consists of the fix where the Dev tool was not compatible with Phalcon version 5.2.3

Thanks

rudiservo commented 11 months ago

@abiral could you change this PR to 5.0.x branch instead of master please?

abiral commented 11 months ago

@rudiservo Thanks for the comment. It's done

rudiservo commented 10 months ago

@abiral sorry, we have another PR that has these changes and a lot more that addresses full compatibility with phalcon5 and php8. Thanks you for your contribution anyway.

www3b commented 10 months ago

@abiral sorry, we have another PR that has these changes and a lot more that addresses full compatibility with phalcon5 and php8. Thanks you for your contribution anyway.

When will the PR be merged?