search

phallstrom / slackistrano

Slack integration for Capistrano deployments.
MIT License
373 stars 74 forks source link

Add slack:deploy:rollback task #31

Closed jdowning closed 9 years ago

jdowning commented 9 years ago

This addresses issue #19. Here, we are adding a slack:deploy:rollback task that hooks into the Capistrano deploy:finishing_rollback task. This task includes all the same variables available to similar tasks like starting, finished, and failed.

Additionally, in order to differentiate between a deployment finishing and a rollback finishing, the slack:deploy:finished task was moved to the Capistrano deploy:finishing task.

Judging by the difference between a rollback and a deploy, using the finishing tasks seems more appropriate long term.

@phallstrom Should this change agree with you, I suggest a 1.0 release to mark a major/API change (in case any users are depending on using deploy:finished). :green_heart:

phallstrom commented 9 years ago

@justindowning I like it! Question... as it stands now when I rollback I'll get a "user has started deploying..." message as we run our 'starting' task after capistrano's 'starting' task (which is run on both deploy and rollback). What are your thoughts on tweaking that so that we run two 'starting' tasks.. one for 'updating' and one for 'reverting'.

phallstrom commented 9 years ago

@justindowning I think I ought to do it. Still curious to hear your thoughts, but I'm gonna start tweaking.

phallstrom commented 9 years ago

@justindowning Thanks for getting the ball rolling on this. I took it and ran a little bit (not much). Version 1.0.0 pushed to rubygems. Changed your :rollback name a little bit. See the changelog for details.

👍

jdowning commented 9 years ago

Awesome!! :heart_eyes:

Changes looks good -- happy to see you get to 1.0.0 too!