search

phallstrom / slackistrano

Slack integration for Capistrano deployments.
MIT License
373 stars 74 forks source link

Add :slack_time_elapsed options #41

Closed spk closed 8 years ago

spk commented 8 years ago

This allow to have elapsed time on the fields at the end of the deploy.

Time elapsed (sec)
103
phallstrom commented 8 years ago

The goal of this is to show the total time it took to deploy?

spk commented 8 years ago

Yes, I had to do that on the gem because it have to be called on the updated action, what do you think of the implementation ?

phallstrom commented 8 years ago

It's fine. I may not merge it as is though. I have a number of open requests to support more formatting options and I kind of feel like this fits more in with that (although keeping track of the time internally and making it available isn't "formatting"). So I think I'll take part of this and leave the other part until I add a more customizable formatting solution which you could then tie into. Appreciate the idea and initial work!

phallstrom commented 8 years ago

@spk Finally getting around to working on slackistrano again. Doing a rewrite that will let folks go nuts with formatting without me having to support every option out there. You can check it out on the overhaul branch if you want.

I've added an elapsed time helper there as well via 0ad960d52b288741efad098334d03804b09887e8.