phallstrom / slackistrano

Slack integration for Capistrano deployments.
MIT License
373 stars 74 forks source link

Catch up to changing Capistrano 3.5.0 with specs #47

Closed dshmelev closed 8 years ago

dshmelev commented 8 years ago

Capistrano 3.5.0 has many changes.

https://github.com/capistrano/capistrano/blob/master/CHANGELOG.md#350 In order to notify Slack using Slackistrano, I think that it is necessary to catch up with some changes.

Thanks you @machupicchubeta

machupicchubeta commented 8 years ago

👍 ✨

zstarer commented 8 years ago

this worked for me 👍 !

nimashariatian commented 8 years ago

this is great! can you please review and merge?

phallstrom commented 8 years ago

Soon. Need to see how this will affect folks using older versions of Capistrano. Don't want to [totally] yank the rug out from them.

Mostly just need to find some time to do it 😀

nimashariatian commented 8 years ago

great, thank you!

machupicchubeta commented 8 years ago

I think that the essence of this Pull Request has been imported into Slackistrano Version 3.0.0. Thank you @phallstrom

phallstrom commented 8 years ago

@machupicchubeta I believe so too. Appreciate the 3.5.0 dry run stuff. I knew that was coming, but wasn't sure when it would hit. Thanks much!