phalt / swapi

*NOT MAINTAINED - NO GUARENTEE TO BE UP*
https://phalt.github.io/pokeapi-and-swapi-going-forward/
BSD 3-Clause "New" or "Revised" License
892 stars 507 forks source link

Replaced "homeworld": null with "homeworld": "n/a" in species.json #117

Open kylesurowiec opened 5 years ago

kylesurowiec commented 5 years ago

Replaced "homeworld": null with "homeworld": "n/a" for species 2 to be consistent with the rest of the API.

I don't believe the null was intended. In my case it actually broke the wrapper I've been writing since I hadn't seen any other null types come through.

d-jo commented 5 years ago

Good change, improves consistency

@phalt