phalt / swapi

*NOT MAINTAINED - NO GUARENTEE TO BE UP*
https://phalt.github.io/pokeapi-and-swapi-going-forward/
BSD 3-Clause "New" or "Revised" License
891 stars 505 forks source link

Brief Character Descriptions #41

Open tbone849 opened 8 years ago

tbone849 commented 8 years ago

It would be nice if each character had a sentence or two description. It would really tie the data together nicely. Knowing their physical characteristics just doesn't seem enough in this case. I am only proposing this for the characters.

Example:

name: 'Anakin Skywalker', bio: 'Anakin Skywalker was a Force-sensitive human male who served the Galactic Republic as a Jedi Knight, and later the Galactic Empire as the Sith Lord Darth Vader.'

(Bio was one-liner from wookiepedia)

walterg2 commented 8 years ago

What if this just became

name: 'Anakin Skywalker',
description: 'Anakin Skywalker was a Force-sensitive human male who served the Galactic Republic as a Jedi Knight, and later the Galactic Empire as the Sith Lord Darth Vader.'

This way, you can also add it to the other items:

name: 'Aleraan'
description: 'From space, the planet of Alderaan, located in the star system of the same name, appeared as a blue-green orb envelopped in a white web of clouds. Its surface had vast bodies of water and was covered in snow-capped mountains, with patches of green grassy hills. Alderaan was known to the galaxy as "the planet of beauty." Famous natural landmarks of Alderaan included the Cloudshape Falls and the Isatabith rain forest.'
name: 'TIE Bomber',
description: 'The TIE bomber was a bombing variant of the TIE line used by the Galactic Empire, and was their main source of anti-emplacement air-support.'
tbone849 commented 8 years ago

Originally I was just thinking characters, but looking back on this, what you proposed would be awesome!

euanwho commented 8 years ago

Is this going to happen guys?

phalt commented 8 years ago

@euanwho we're accepting pull requests :)

euanwho commented 8 years ago

Feel free to assign this to me!

phalt commented 8 years ago

@euanwho it's all yours!

euanwho commented 8 years ago

I've submitted a pull request, but there are a couple of errors that I don't understand. Maybe someone could help